Optimal error analysis of spectral methods with emphasis on non-constant coefficients and deformed geometries